Skip to content

Commit c8845f5

Browse files
committed
Auto merge of #2206 - JohnTitor:no-observers, r=locks
Bump eslint-plugin-ember from 7.7.2 to 7.8.1 `no-observers` now complains imports. We can also disable at file level, it's an option. Closes #2198 r? @locks
2 parents 28216b3 + 7a09db1 commit c8845f5

File tree

5 files changed

+25
-24
lines changed

5 files changed

+25
-24
lines changed

app/controllers/crate/version.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { inject as service } from '@ember/service';
33
import Controller from '@ember/controller';
44
import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
55
import ArrayProxy from '@ember/array/proxy';
6+
// eslint-disable-next-line ember/no-observers
67
import { computed, observer } from '@ember/object';
78
import moment from 'moment';
89

app/mixins/rl-dropdown-component.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import Mixin from '@ember/object/mixin';
2+
// eslint-disable-next-line ember/no-observers
23
import { observer } from '@ember/object';
34
import { on } from '@ember/object/evented';
45
import { bind, later } from '@ember/runloop';

app/routes/crate/version.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// eslint-disable-next-line ember/no-observers
12
import { observer } from '@ember/object';
23
import Route from '@ember/routing/route';
34
import { inject as service } from '@ember/service';

package-lock.json

Lines changed: 21 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
"ember-window-mock": "^0.6.0",
8181
"eslint": "^6.8.0",
8282
"eslint-config-prettier": "^6.10.0",
83-
"eslint-plugin-ember": "^7.7.2",
83+
"eslint-plugin-ember": "^7.8.1",
8484
"eslint-plugin-prettier": "^3.1.2",
8585
"loader.js": "^4.7.0",
8686
"normalize.css": "^8.0.1",

0 commit comments

Comments
 (0)