Auto merge of #1543 - pwoolcoc:allow-multiple-keywords-in-search, r=jtgeibel

Allow multiple keywords in crate search

This PR allows URLs like crates.io/search?all_keywords=gotham+middleware to enable linking to a search that returns crates that have all keywords specified in the parameter.

Towards #1461

Author: bors

app/controllers/application.js

@@ -28,6 +28,7 @@ export default Controller.extend(EKMixin, {
         queryParams: {
           q: this.searchQuery,
           page: 1,
+          all_keywords: null,
         },
       });
     },

app/controllers/search.js

@@ -9,7 +9,7 @@ import PaginationMixin from '../mixins/pagination';
 
 export default Controller.extend(PaginationMixin, {
   search: service(),
-  queryParams: ['q', 'page', 'per_page', 'sort'],
+  queryParams: ['all_keywords', 'page', 'per_page', 'q', 'sort'],
   q: alias('search.q'),
   page: '1',
   per_page: 10,

app/routes/search.js

@@ -2,8 +2,9 @@ import Route from '@ember/routing/route';
 
 export default Route.extend({
   queryParams: {
-    q: { refreshModel: true },
+    all_keywords: { refreshModel: true },
     page: { refreshModel: true },
+    q: { refreshModel: true },
     sort: { refreshModel: true },
   },
 

migrations/2019-06-14-175833_change_keywords_to_text/down.sql

@@ -0,0 +1 @@
+ALTER TABLE keywords ALTER COLUMN keyword TYPE varchar;

migrations/2019-06-14-175833_change_keywords_to_text/up.sql

@@ -0,0 +1 @@
+ALTER TABLE keywords ALTER COLUMN keyword TYPE text;

src/controllers/krate/search.rs

@@ -96,7 +96,28 @@ pub fn search(req: &mut dyn Request) -> AppResult<Response> {
         );
     }
 
-    if let Some(kw) = params.get("keyword") {
+    if let Some(kws) = params.get("all_keywords") {
+        use diesel::sql_types::Array;
+        sql_function!(#[aggregate] fn array_agg<T>(x: T) -> Array<T>);
+
+        let names: Vec<_> = kws
+            .split_whitespace()
+            .map(|name| name.to_lowercase())
+            .collect();
+
+        query = query.filter(
+            // FIXME: Just use `.contains` in Diesel 2.0
+            // https://github.com/diesel-rs/diesel/issues/2066
+            Contains::new(
+                crates_keywords::table
+                    .inner_join(keywords::table)
+                    .filter(crates_keywords::crate_id.eq(crates::id))
+                    .select(array_agg(keywords::keyword))
+                    .single_value(),
+                names.into_sql::<Array<Text>>(),
+            ),
+        );
+    } else if let Some(kw) = params.get("keyword") {
         query = query.filter(
             crates::id.eq_any(
                 crates_keywords::table
@@ -227,3 +248,5 @@ pub fn search(req: &mut dyn Request) -> AppResult<Response> {
         },
     }))
 }
+
+diesel_infix_operator!(Contains, "@>");

src/schema.rs

@@ -550,10 +550,10 @@ table! {
         id -> Int4,
         /// The `keyword` column of the `keywords` table.
         ///
-        /// Its SQL type is `Varchar`.
+        /// Its SQL type is `Text`.
         ///
         /// (Automatically generated by Diesel.)
-        keyword -> Varchar,
+        keyword -> Text,
         /// The `crates_cnt` column of the `keywords` table.
         ///
         /// Its SQL type is `Int4`.

src/tests/krate.rs

@@ -117,28 +117,34 @@ fn index_queries() {
         CrateBuilder::new("foo", user.id)
             .keyword("kw3")
             .expect_build(conn);
+
+        CrateBuilder::new("two-keywords", user.id)
+            .keyword("kw1")
+            .keyword("kw3")
+            .expect_build(conn);
         (krate, krate2)
     });
 
     assert_eq!(anon.search("q=baz").meta.total, 0);
 
     // All of these fields should be indexed/searched by the queries
     assert_eq!(anon.search("q=foo").meta.total, 2);
-    assert_eq!(anon.search("q=kw1").meta.total, 2);
+    assert_eq!(anon.search("q=kw1").meta.total, 3);
     assert_eq!(anon.search("q=readme").meta.total, 1);
     assert_eq!(anon.search("q=description").meta.total, 1);
 
-    assert_eq!(anon.search_by_user_id(user.id).crates.len(), 3);
+    assert_eq!(anon.search_by_user_id(user.id).crates.len(), 4);
     assert_eq!(anon.search_by_user_id(0).crates.len(), 0);
 
     assert_eq!(anon.search("letter=F").crates.len(), 2);
     assert_eq!(anon.search("letter=B").crates.len(), 1);
     assert_eq!(anon.search("letter=b").crates.len(), 1);
     assert_eq!(anon.search("letter=c").crates.len(), 0);
 
-    assert_eq!(anon.search("keyword=kw1").crates.len(), 2);
-    assert_eq!(anon.search("keyword=KW1").crates.len(), 2);
+    assert_eq!(anon.search("keyword=kw1").crates.len(), 3);
+    assert_eq!(anon.search("keyword=KW1").crates.len(), 3);
     assert_eq!(anon.search("keyword=kw2").crates.len(), 0);
+    assert_eq!(anon.search("all_keywords=kw1 kw3").crates.len(), 1);
 
     assert_eq!(anon.search("q=foo&keyword=kw1").crates.len(), 1);
     assert_eq!(anon.search("q=foo2&keyword=kw1").crates.len(), 0);