Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link-time dependency on core: use of #[inline] functions #491

Open
fee1-dead opened this issue Sep 3, 2022 · 2 comments
Open

Link-time dependency on core: use of #[inline] functions #491

fee1-dead opened this issue Sep 3, 2022 · 2 comments

Comments

@fee1-dead
Copy link
Member

See also rust-lang/rust#100759 (comment). This is undesirable as it causes a confusing linker error when modifying the library functions. #472 was opened to fixed this, but it was closed because it looked like adding #[inline] to fix this had been more appropriate. I encountered this issue again in the link above and I am creating this issue for further discussion as to whether this is an issue or not.

@Amanieu
Copy link
Member

Amanieu commented Sep 5, 2022

compiler-builtins depends on a ton of inline functions in core, such as wrapping_add. I don't think it is reasonable for us to avoid using these functions entirely.

@RalfJung
Copy link
Member

RalfJung commented Oct 9, 2022

I just spent almost an hour debugging strange linker errors until I realized they are caused by compiler_builtins and this bug. The current situation seems pretty fragile and it'd be great to find some proper solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants