Skip to content

doctest should also print Running runner for consistent #15431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loynoir opened this issue Apr 16, 2025 · 1 comment
Open

doctest should also print Running runner for consistent #15431

loynoir opened this issue Apr 16, 2025 · 1 comment
Labels
A-doctests Area: rustdoc --test C-bug Category: bug Command-test S-triage Status: This issue is waiting on initial triage.

Comments

@loynoir
Copy link

loynoir commented Apr 16, 2025

Problem

test does print Running runner.

  • Running `/path/to/runner-ssh-aarch64-linux-android.sh ...`
       Fresh doctest_example v0.1.0 (/path/to/doctest_example)
      Timing report saved to /path/to/target/cargo-timings/cargo-timing-XXX.html
    Finished `XXX` profile [optimized] target(s) in 0.01s
     Running `/path/to/runner-ssh-aarch64-linux-android.sh /path/to/target/aarch64-linux-android/XXX/deps/doctest_example-XXX`

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

doctest does not print Running runner, which is not consistent.

   Doc-tests doctest_example
     Running `/home/vscode/.rustup/toolchains/nightly-2025-04-14-x86_64-unknown-linux-gnu/bin/rustdoc ...`
WARNING: No rustdoc doctest environment variable provided so doctests will be run in the same process

running 1 test
test doctest_example/src/lib.rs - add (line 3) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Steps

No response

Possible Solution(s)

doctest should also print Running runner for consistent

  • [PATCH] Running `/path/to/runner-ssh-aarch64-linux-android.sh /path/to/target/XXX/path/to/doctest/merged_doctest_2024/rust_out`
       Fresh doctest_example v0.1.0 (/path/to/doctest_example)
      Timing report saved to /path/to/target/cargo-timings/cargo-timing-XXX.html
    Finished `XXX` profile [optimized] target(s) in 0.01s
     Running `/path/to/runner-ssh-aarch64-linux-android.sh /path/to/target/aarch64-linux-android/XXX/deps/doctest_example-XXX`

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests doctest_example
     Running `/home/vscode/.rustup/toolchains/nightly-2025-04-14-x86_64-unknown-linux-gnu/bin/rustdoc ...`
     [PATCH] Running `/path/to/runner-ssh-aarch64-linux-android.sh /path/to/target/XXX/path/to/doctest/merged_doctest_2024/rust_out`
WARNING: No rustdoc doctest environment variable provided so doctests will be run in the same process

running 1 test
test doctest_example/src/lib.rs - add (line 3) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Notes

No response

Version

channel = "nightly-2025-04-14"
@loynoir loynoir added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Apr 16, 2025
@epage epage added Command-test A-doctests Area: rustdoc --test labels Apr 16, 2025
@epage
Copy link
Contributor

epage commented Apr 16, 2025

Currently, cargo test delegates compiling, running, and reporting of doctests to rustdoc. For this to be fixed in the short term, that would be on rustdoc.

Long term, I'd like to make this less special and run like any other test which would resolve this. Keeping this open for now for that.

Note: #8889 may get rid of Running completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-doctests Area: rustdoc --test C-bug Category: bug Command-test S-triage Status: This issue is waiting on initial triage.
Projects
Status: No status
Development

No branches or pull requests

2 participants