Skip to content

CARGO_UNSTABLE_BUILD_STD doesn't support multiple crates anymore #15064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nemo157 opened this issue Jan 14, 2025 · 2 comments · Fixed by #15065
Closed

CARGO_UNSTABLE_BUILD_STD doesn't support multiple crates anymore #15064

Nemo157 opened this issue Jan 14, 2025 · 2 comments · Fixed by #15065
Assignees
@weihanglo
Labels
C-bug Category: bug regression-from-stable-to-nightly Regression in nightly that previously worked in stable. S-triage Status: This issue is waiting on initial triage. Z-build-std Nightly: build-std

Comments

@Nemo157
Copy link
Member

Nemo157 commented Jan 14, 2025

Problem

> CARGO_UNSTABLE_BUILD_STD=std,panic_abort cargo run
error: invalid character `,` in package name: `std,panic_abort`, characters must be Unicode XID characters (numbers, `-`, `_`, or most letters)

This works via the CLI arg:

> cargo run -Zbuild-std=std,panic_abort
...
   Compiling std v0.0.0 (/nix/store/gyinl9bb727ajna53pwz034xazca9aqz-rust-minimal-1.85.0-nightly-2025-01-02/lib/rustlib/src/rust/library/std)
...
   Compiling panic_abort v0.0.0 (/nix/store/gyinl9bb727ajna53pwz034xazca9aqz-rust-minimal-1.85.0-nightly-2025-01-02/lib/rustlib/src/rust/library/panic_abort)
...
Hello, world!

Tested on cargo 1.85.0-nightly (d73d2caf9 2024-12-31). This used to work via the env-var too, I didn't fully bisect but at least in cargo 1.84.0-nightly (e75214ea4 2024-10-25) it worked.

Steps

No response

Possible Solution(s)

No response

Notes

No response

Version

cargo 1.85.0-nightly (d73d2caf9 2024-12-31)
release: 1.85.0-nightly
commit-hash: d73d2caf9e41a39daf2a8d6ce60ec80bf354d2a7
commit-date: 2024-12-31
host: x86_64-unknown-linux-gnu
libgit2: 1.8.1 (sys:0.19.0 vendored)
libcurl: 8.9.0-DEV (sys:0.4.74+curl-8.9.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: NixOS 24.11.0 [64-bit]
@Nemo157 Nemo157 added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Jan 14, 2025
@ehuss
Copy link
Contributor

ehuss commented Jan 14, 2025

Thanks for the report!

@weihanglo This seems to have regressed from #14899. Is there a reason that removed the comma splitting?

@ehuss ehuss added Z-build-std Nightly: build-std regression-from-stable-to-nightly Regression in nightly that previously worked in stable. labels Jan 14, 2025
@weihanglo
Copy link
Member

No. It was an overlook

@weihanglo weihanglo self-assigned this Jan 14, 2025
@weihanglo weihanglo mentioned this issue Jan 14, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2025
@epage
fix(build-std): parse as comma-separated list (#15065)
149aa21 
### What does this PR try to resolve?

Restore to the behavior prior to
30d11ce
Also extend `build-std-features` to support comma-separated list.

Fixes #15064

### How should we test and review this PR?

A test has been added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weihanglo weihanglo

Labels
C-bug Category: bug regression-from-stable-to-nightly Regression in nightly that previously worked in stable. S-triage Status: This issue is waiting on initial triage. Z-build-std Nightly: build-std
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build-std): parse as comma-separated list weihanglo/cargo
3 participants
@ehuss @Nemo157 @weihanglo