Skip to content

Commit fd54406

Browse files
committed
chore(ci): Check for clippy correctness
The fact that we don't check for `derive_ord_xor_partial_ord ` almost bit us in #14663. Instead of just enabling this one lint, I figured it'd be good to audit all of the `deny` by default lints. That is long enough that I was concerned about maintaining it (or bikeshedding which to enable or disable). All `deny` by default lints are `correctness` lints and I figure we could just enable the group. We normally opt-in to individual clippy lints. From what I remember of that conversation, it mostly stems from how liberal clippy is with making a lint `warn` by default. It also makes an unpinned CI more brittle. I figured clippy is more conservative about `deny` by default lints and slower to add them that this is unlikely to be a problem.
1 parent 49d8696 commit fd54406

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Cargo.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ rust_2018_idioms = "warn" # TODO: could this be removed?
121121
private_intra_doc_links = "allow"
122122

123123
[workspace.lints.clippy]
124-
all = { level = "allow", priority = -1 }
124+
all = { level = "allow", priority = -2 }
125+
correctness = { level = "warn", priority = -1 }
125126
dbg_macro = "warn"
126127
disallowed_methods = "warn"
127128
print_stderr = "warn"

0 commit comments

Comments
 (0)