Don't depend on ? affecting type inference in weird ways

WaffleLapkin · WaffleLapkin · commit 898969e4a4bd · 2024-04-04T23:56:01.000Z
diff --git a/crates/cargo-util/src/paths.rs b/crates/cargo-util/src/paths.rs
@@ -510,8 +510,7 @@ fn _remove_file(p: &Path) -> Result<()> {
         }
     }
 
-    Err(err).with_context(|| format!("failed to remove file `{}`", p.display()))?;
-    Ok(())
+    Err(err).with_context(|| format!("failed to remove file `{}`", p.display()))
 }
 
 fn set_not_readonly(p: &Path) -> io::Result<bool> {

Original file line number	Diff line number	Diff line change
`@@ -510,8 +510,7 @@ fn _remove_file(p: &Path) -> Result<()> {`
`510`	`510`	`}`
`511`	`511`	`}`
`512`	`512`
`513`		- Err(err).with_context(\|\| format!("failed to remove file `{}`", p.display()))?;
`514`		`- Ok(())`
	`513`	+ Err(err).with_context(\|\| format!("failed to remove file `{}`", p.display()))
`515`	`514`	`}`
`516`	`515`
`517`	`516`	`fn set_not_readonly(p: &Path) -> io::Result<bool> {`