Skip to content

Commit 705c4f1

Browse files
committed
chore(ci): Don't check cargo against beta channel
We already only partially check it and it has been a source of false positives. While there is trust in the job, contributors and maintainers go into the job assuming there is a problem and it takes time to break that assumption. If we lose trust in the job, we then won't trust it when it fails for other reasons. This also increases the risk of us not seeing other problems `bump-checks` is meant to find if the steps in the job get re-arranged to make this one of the early ones.
1 parent b74573b commit 705c4f1

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

crates/xtask-bump-check/src/xtask.rs

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,19 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
118118
let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?;
119119
let status = |msg: &str| gctx.shell().status(STATUS, msg);
120120

121-
// Don't check against beta and stable branches,
122-
// as the publish of these crates are not tied with Rust release process.
123-
// See `TO_PUBLISH` in publish.py.
124-
let crates_not_check_against_channels = ["home"];
121+
let crates_not_check_against_channels = [
122+
// High false positive rate between beta branch and requisite version bump soon after
123+
//
124+
// Low risk because we always bump the "major" version after beta branch; we are
125+
// only losing out on checks for patch releases.
126+
//
127+
// Note: this is already skipped in `changed`
128+
"cargo",
129+
// Don't check against beta and stable branches,
130+
// as the publish of these crates are not tied with Rust release process.
131+
// See `TO_PUBLISH` in publish.py.
132+
"home",
133+
];
125134

126135
status(&format!("base commit `{}`", base_commit.id()))?;
127136
status(&format!("head commit `{}`", head_commit.id()))?;

0 commit comments

Comments
 (0)