Skip to content

Commit 6fe6437

Browse files
borsweihanglo
authored andcommitted
Auto merge of #11610 - ehuss:disable-public-network-windows, r=epage
Disable network SSH tests on windows. These tests have a high failure rate on Windows, so this disables them for now. I don't know exactly why they are failing. If I had to take a wild guess, I would suspect the use of WinCNG for the SSH backend, which may mean it is out of our control.
1 parent 5bd7a2c commit 6fe6437

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

tests/testsuite/ssh.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,10 @@ Caused by:
386386
}
387387

388388
#[cargo_test(public_network_test)]
389+
// For unknown reasons, this test occasionally fails on Windows with a
390+
// LIBSSH2_ERROR_KEY_EXCHANGE_FAILURE error:
391+
// failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23)
392+
#[cfg_attr(windows, ignore = "test is flaky on windows")]
389393
fn invalid_github_key() {
390394
// A key for github.com in known_hosts should override the built-in key.
391395
// This uses a bogus key which should result in an error.
@@ -417,6 +421,10 @@ fn invalid_github_key() {
417421
}
418422

419423
#[cargo_test(public_network_test)]
424+
// For unknown reasons, this test occasionally fails on Windows with a
425+
// LIBSSH2_ERROR_KEY_EXCHANGE_FAILURE error:
426+
// failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23)
427+
#[cfg_attr(windows, ignore = "test is flaky on windows")]
420428
fn bundled_github_works() {
421429
// The bundled key for github.com works.
422430
//

0 commit comments

Comments
 (0)