Skip to content

Commit 337092c

Browse files
Shankar Mathiah NanjundanShankar Mathiah Nanjundan
Shankar Mathiah Nanjundan
authored and
Shankar Mathiah Nanjundan
committed
Fix warning message
1 parent 1992803 commit 337092c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/cargo/ops/cargo_new.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,7 @@ fn check_name(
261261
let name_in_lowercase = name.to_lowercase();
262262
if name != name_in_lowercase {
263263
shell.warn(format!(
264-
"package `{}` should have a lowercase name such as `{}`",
265-
name, name_in_lowercase
264+
"the name `{name}` is not snake_case or kebab-case which is recommended for package names, consider `{name_in_lowercase}`"
266265
))?;
267266
}
268267

tests/testsuite/new.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ fn non_ascii_name() {
451451
"\
452452
[WARNING] the name `Привет` contains non-ASCII characters
453453
Non-ASCII crate names are not supported by Rust.
454-
[WARNING] package `Привет` should have a lowercase name such as `привет`
454+
[WARNING] the name `Привет` is not snake_case or kebab-case which is recommended for package names, consider `привет`
455455
[CREATED] binary (application) `Привет` package
456456
",
457457
)
@@ -507,7 +507,7 @@ fn non_snake_case_name() {
507507
cargo_process("new UPPERcase_name")
508508
.with_stderr(
509509
"\
510-
[WARNING] package `UPPERcase_name` should have a lowercase name such as `uppercase_name`
510+
[WARNING] the name `UPPERcase_name` is not snake_case or kebab-case which is recommended for package names, consider `uppercase_name`
511511
[CREATED] binary (application) `UPPERcase_name` package
512512
",
513513
)

0 commit comments

Comments
 (0)