Auto merge of #13367 - epage:new-creating, r=weihanglo

fix(new): Print a 'Creating', rather than 'Created' status

### What does this PR try to resolve?

This has bothered me about `cargo new` and `cargo init` for a while that
the output is read backwards, for example:
```diff
--- i/tests/testsuite/cargo_init/path_contains_separator/stderr.log
+++ w/tests/testsuite/cargo_init/path_contains_separator/stderr.log
`@@` -1,3 +1,3 `@@`
+    Creating binary (application) package
 warning: the path `[ROOT]/case/test:ing/.` contains invalid PATH characters (usually `:`, `;`, or `"`)
 It is recommended to use a different name to avoid problems.
-     Created binary (application) package
```

### How should we test and review this PR?

### Additional information

Author: bors

crates/cargo-test-support/src/compare.rs

@@ -192,6 +192,7 @@ fn substitute_macros(input: &str) -> String {
         ("[CHECKING]", "    Checking"),
         ("[COMPLETED]", "   Completed"),
         ("[CREATED]", "     Created"),
+        ("[CREATING]", "    Creating"),
         ("[CREDENTIAL]", "  Credential"),
         ("[DOWNGRADING]", " Downgrading"),
         ("[FINISHED]", "    Finished"),

src/bin/cargo/commands/init.rs

@@ -21,9 +21,6 @@ pub fn cli() -> Command {
 
 pub fn exec(config: &mut Config, args: &ArgMatches) -> CliResult {
     let opts = args.new_options(config)?;
-    let project_kind = ops::init(&opts, config)?;
-    config
-        .shell()
-        .status("Created", format!("{} package", project_kind))?;
+    ops::init(&opts, config)?;
     Ok(())
 }

src/bin/cargo/commands/new.rs

@@ -23,15 +23,5 @@ pub fn exec(config: &mut Config, args: &ArgMatches) -> CliResult {
     let opts = args.new_options(config)?;
 
     ops::new(&opts, config)?;
-    let path = args.get_one::<String>("path").unwrap();
-    let package_name = if let Some(name) = args.get_one::<String>("name") {
-        name
-    } else {
-        path
-    };
-    config.shell().status(
-        "Created",
-        format!("{} `{}` package", opts.kind, package_name),
-    )?;
     Ok(())
 }

src/cargo/ops/cargo_new.rs

@@ -439,19 +439,22 @@ fn calculate_new_project_kind(
 
 pub fn new(opts: &NewOptions, config: &Config) -> CargoResult<()> {
     let path = &opts.path;
+    let name = get_name(path, opts)?;
+    config
+        .shell()
+        .status("Creating", format!("{} `{}` package", opts.kind, name))?;
+
     if path.exists() {
         anyhow::bail!(
             "destination `{}` already exists\n\n\
              Use `cargo init` to initialize the directory",
             path.display()
         )
     }
-
     check_path(path, &mut config.shell())?;
 
     let is_bin = opts.kind.is_bin();
 
-    let name = get_name(path, opts)?;
     check_name(name, opts.name.is_none(), is_bin, &mut config.shell())?;
 
     let mkopts = MkOptions {
@@ -480,20 +483,19 @@ pub fn init(opts: &NewOptions, config: &Config) -> CargoResult<NewProjectKind> {
     }
 
     let path = &opts.path;
+    let name = get_name(path, opts)?;
+    let mut src_paths_types = vec![];
+    detect_source_paths_and_types(path, name, &mut src_paths_types)?;
+    let kind = calculate_new_project_kind(opts.kind, opts.auto_detect_kind, &src_paths_types);
+    config
+        .shell()
+        .status("Creating", format!("{} package", opts.kind))?;
 
     if path.join("Cargo.toml").exists() {
         anyhow::bail!("`cargo init` cannot be run on existing Cargo packages")
     }
-
     check_path(path, &mut config.shell())?;
 
-    let name = get_name(path, opts)?;
-
-    let mut src_paths_types = vec![];
-
-    detect_source_paths_and_types(path, name, &mut src_paths_types)?;
-
-    let kind = calculate_new_project_kind(opts.kind, opts.auto_detect_kind, &src_paths_types);
     let has_bin = kind.is_bin();
 
     if src_paths_types.is_empty() {

tests/testsuite/bad_config.rs

@@ -105,6 +105,7 @@ fn bad4() {
         .with_status(101)
         .with_stderr(
             "\
+[CREATING] binary (application) `foo` package
 [ERROR] Failed to create package `foo` at `[..]`
 
 Caused by:

tests/testsuite/cargo_init/auto_git/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/bin_already_exists_explicit/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/bin_already_exists_explicit_nosrc/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/bin_already_exists_implicit/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/bin_already_exists_implicit_namenosrc/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/bin_already_exists_implicit_namesrc/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/bin_already_exists_implicit_nosrc/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/cant_create_library_when_both_binlib_present/stderr.log

@@ -1 +1,2 @@
+    Creating library package
 error: cannot have a package with multiple libraries, found both `case.rs` and `lib.rs`

tests/testsuite/cargo_init/creates_binary_when_both_binlib_present/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/creates_binary_when_instructed_and_has_lib_file/stderr.log

@@ -1,2 +1,2 @@
+    Creating binary (application) package
 warning: file `case.rs` seems to be a library file
-     Created binary (application) package

tests/testsuite/cargo_init/creates_library_when_instructed_and_has_bin_file/stderr.log

@@ -1,2 +1,2 @@
+    Creating library package
 warning: file `case.rs` seems to be a binary (application) file
-     Created library package

tests/testsuite/cargo_init/explicit_bin_with_git/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/formats_source/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/fossil_autodetect/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/git_autodetect/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/git_ignore_exists_no_conflicting_entries/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/ignores_failure_to_format_source/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/inferred_bin_with_git/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/inferred_lib_with_git/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating binary (application) package

tests/testsuite/cargo_init/inherit_workspace_package_table/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/invalid_dir_name/stderr.log

@@ -1,3 +1,4 @@
+    Creating binary (application) package
 error: invalid character `.` in package name: `foo.bar`, characters must be Unicode XID characters (numbers, `-`, `_`, or most letters)
 If you need a package name to not match the directory name, consider using --name flag.
 If you need a binary with the name "foo.bar", use a valid package name, and set the binary name to be different from the package. This can be done by setting the binary filename to `src/bin/foo.bar.rs` or change the name in Cargo.toml with:

tests/testsuite/cargo_init/lib_already_exists_nosrc/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating binary (application) package

tests/testsuite/cargo_init/lib_already_exists_src/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating binary (application) package

tests/testsuite/cargo_init/mercurial_autodetect/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/path_contains_separator/stderr.log

@@ -1,3 +1,3 @@
+    Creating binary (application) package
 warning: the path `[ROOT]/case/test:ing/.` contains invalid PATH characters (usually `:`, `;`, or `"`)
 It is recommended to use a different name to avoid problems.
-     Created binary (application) package

tests/testsuite/cargo_init/pijul_autodetect/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/reserved_name/stderr.log

@@ -1,3 +1,4 @@
+    Creating binary (application) package
 error: the name `test` cannot be used as a package name, it conflicts with Rust's built-in test library
 If you need a package name to not match the directory name, consider using --name flag.
 If you need a binary with the name "test", use a valid package name, and set the binary name to be different from the package. This can be done by setting the binary filename to `src/bin/test.rs` or change the name in Cargo.toml with:

tests/testsuite/cargo_init/simple_bin/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/simple_git/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/simple_git_ignore_exists/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/simple_hg/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/simple_hg_ignore_exists/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/simple_lib/stderr.log

@@ -1 +1 @@
-     Created library package
+    Creating library package

tests/testsuite/cargo_init/with_argument/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_init/workspace_add_member/stderr.log

@@ -1 +1 @@
-     Created binary (application) package
+    Creating binary (application) package

tests/testsuite/cargo_new/add_members_to_workspace_format_previous_items/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/add_members_to_workspace_format_sorted/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/add_members_to_workspace_with_absolute_package_path/stderr.log

@@ -1 +1 @@
-     Created binary (application) `[ROOT]/case/crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/add_members_to_workspace_with_empty_members/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/add_members_to_workspace_with_exclude_list/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/add_members_to_workspace_with_members_glob/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/empty_name/stderr.log

@@ -1 +1,2 @@
+    Creating binary (application) `` package
 error: package name cannot be empty

tests/testsuite/cargo_new/inherit_workspace_lints/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/inherit_workspace_package_table/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/inherit_workspace_package_table_with_edition/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/inherit_workspace_package_table_with_registry/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/inherit_workspace_package_table_without_version/stderr.log

@@ -1 +1 @@
-     Created binary (application) `crates/foo` package
+    Creating binary (application) `foo` package

tests/testsuite/cargo_new/not_inherit_workspace_package_table_if_not_members/stderr.log

@@ -1 +1 @@
-     Created binary (application) `bar` package
+    Creating binary (application) `bar` package