Skip to content

Commit 0bde1c3

Browse files
authored
Rollup merge of rust-lang#74374 - cuviper:lto-bitcode-1.45, r=Mark-Simulacrum
Add a 1.45 release note on lto vs. embed-bitcode I added a bullet for Cargo's use of `embed-bitcode`, since that was even noteworthy enough for the Inside Rust blog. Then more importantly, I added a compatibility note for how this may interact poorly with manually enabling LTO. r? @Mark-Simulacrum
2 parents c43a115 + 2ba58f9 commit 0bde1c3

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

RELEASES.md

+10
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ Stabilized APIs
8282
Cargo
8383
-----
8484

85+
- [Cargo uses the `embed-bitcode` flag to optimize disk usage and build
86+
time.][cargo/8066]
87+
8588
Misc
8689
----
8790
- [Rustdoc now supports strikethrough text in Markdown.][71928] E.g.
@@ -97,12 +100,18 @@ Compatibility Notes
97100
- [Rustdoc's CLI's extra error exit codes have been removed.][71900] These were
98101
previously undocumented and not intended for public use. Rustdoc still provides
99102
a non-zero exit code on errors.
103+
- [Rustc's `lto` flag is incompatible with the new `embed-bitcode=no`.][71848]
104+
This may cause issues if LTO is enabled through `RUSTFLAGS` or `cargo rustc`
105+
flags while cargo is adding `embed-bitcode` itself. The recommended way to
106+
control LTO is with Cargo profiles, either in `Cargo.toml` or `.cargo/config`,
107+
or by setting `CARGO_PROFILE_<name>_LTO` in the environment.
100108

101109
Internals Only
102110
--------------
103111
- [Make clippy a git subtree instead of a git submodule][70655]
104112
- [Unify the undo log of all snapshot types][69464]
105113

114+
[71848]: https://github.com/rust-lang/rust/issues/71848/
106115
[73420]: https://github.com/rust-lang/rust/issues/73420/
107116
[72324]: https://github.com/rust-lang/rust/pull/72324/
108117
[71843]: https://github.com/rust-lang/rust/pull/71843/
@@ -129,6 +138,7 @@ Internals Only
129138
[69813]: https://github.com/rust-lang/rust/pull/69813/
130139
[69464]: https://github.com/rust-lang/rust/pull/69464/
131140
[68717]: https://github.com/rust-lang/rust/pull/68717/
141+
[cargo/8066]: https://github.com/rust-lang/cargo/pull/8066
132142
[`Arc::as_ptr`]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.as_ptr
133143
[`BTreeMap::remove_entry`]: https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.remove_entry
134144
[`Rc::as_ptr`]: https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.as_ptr

0 commit comments

Comments
 (0)