Skip to content

Commit 506264e

Browse files
Philippe-Choletjswrenn
authored andcommitted
Unalias MergeBy
1 parent 5f47287 commit 506264e

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

src/merge_join.rs

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,20 @@ where
5151
/// Iterator element type is `I::Item`.
5252
///
5353
/// See [`.merge_by()`](crate::Itertools::merge_by) for more information.
54-
pub type MergeBy<I, J, F> = InternalMergeJoinBy<I, J, F>;
54+
#[must_use = "iterator adaptors are lazy and do nothing unless consumed"]
55+
pub struct MergeBy<I: Iterator, J: Iterator, F> {
56+
left: PutBack<Fuse<I>>,
57+
right: PutBack<Fuse<J>>,
58+
cmp_fn: F,
59+
}
5560

5661
/// Create a `MergeBy` iterator.
5762
pub fn merge_by_new<I, J, F>(a: I, b: J, cmp: F) -> MergeBy<I::IntoIter, J::IntoIter, F>
5863
where
5964
I: IntoIterator,
6065
J: IntoIterator<Item = I::Item>,
6166
{
62-
InternalMergeJoinBy {
67+
MergeBy {
6368
left: put_back(a.into_iter().fuse()),
6469
right: put_back(b.into_iter().fuse()),
6570
cmp_fn: cmp,
@@ -79,7 +84,7 @@ where
7984
J: IntoIterator,
8085
F: FnMut(&I::Item, &J::Item) -> T,
8186
{
82-
InternalMergeJoinBy {
87+
MergeBy {
8388
left: put_back(left.into_iter().fuse()),
8489
right: put_back(right.into_iter().fuse()),
8590
cmp_fn: MergeFuncLR(cmp_fn, PhantomData),
@@ -89,18 +94,8 @@ where
8994
/// An iterator adaptor that merge-joins items from the two base iterators in ascending order.
9095
///
9196
/// See [`.merge_join_by()`](crate::Itertools::merge_join_by) for more information.
92-
pub type MergeJoinBy<I, J, F> = InternalMergeJoinBy<
93-
I,
94-
J,
95-
MergeFuncLR<F, <F as FuncLR<<I as Iterator>::Item, <J as Iterator>::Item>>::T>,
96-
>;
97-
98-
#[must_use = "iterator adaptors are lazy and do nothing unless consumed"]
99-
pub struct InternalMergeJoinBy<I: Iterator, J: Iterator, F> {
100-
left: PutBack<Fuse<I>>,
101-
right: PutBack<Fuse<J>>,
102-
cmp_fn: F,
103-
}
97+
pub type MergeJoinBy<I, J, F> =
98+
MergeBy<I, J, MergeFuncLR<F, <F as FuncLR<<I as Iterator>::Item, <J as Iterator>::Item>>::T>>;
10499

105100
#[derive(Clone, Debug)]
106101
pub struct MergeFuncLR<F, T>(F, PhantomData<T>);
@@ -219,7 +214,7 @@ impl<T: PartialOrd> OrderingOrBool<T, T> for MergeLte {
219214
}
220215
}
221216

222-
impl<I, J, F> Clone for InternalMergeJoinBy<I, J, F>
217+
impl<I, J, F> Clone for MergeBy<I, J, F>
223218
where
224219
I: Iterator,
225220
J: Iterator,
@@ -230,17 +225,17 @@ where
230225
clone_fields!(left, right, cmp_fn);
231226
}
232227

233-
impl<I, J, F> fmt::Debug for InternalMergeJoinBy<I, J, F>
228+
impl<I, J, F> fmt::Debug for MergeBy<I, J, F>
234229
where
235230
I: Iterator + fmt::Debug,
236231
I::Item: fmt::Debug,
237232
J: Iterator + fmt::Debug,
238233
J::Item: fmt::Debug,
239234
{
240-
debug_fmt_fields!(InternalMergeJoinBy, left, right);
235+
debug_fmt_fields!(MergeBy, left, right);
241236
}
242237

243-
impl<I, J, F, T> Iterator for InternalMergeJoinBy<I, J, F>
238+
impl<I, J, F, T> Iterator for MergeBy<I, J, F>
244239
where
245240
I: Iterator,
246241
J: Iterator,
@@ -340,7 +335,7 @@ where
340335
}
341336
}
342337

343-
impl<I, J, F, T> FusedIterator for InternalMergeJoinBy<I, J, F>
338+
impl<I, J, F, T> FusedIterator for MergeBy<I, J, F>
344339
where
345340
I: Iterator,
346341
J: Iterator,

0 commit comments

Comments
 (0)