make register reader/writer copiable, return writer #738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rust-embedded/tools
Do anyone see disadvantage of using value instead of mutable reference for writer?
Related to #708
Big breaking change.
This does not let you create writer outside of
write
as suggested by #708, but lets to reuse of writer.for example
this
can be optimized to
R<REG>
->W<REG>
conversion could be added also. Unsafe?