Skip to content

Integrate mio support #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kixunil opened this issue Nov 10, 2016 · 4 comments
Closed

Integrate mio support #22

Kixunil opened this issue Nov 10, 2016 · 4 comments

Comments

@Kixunil
Copy link

Kixunil commented Nov 10, 2016

I believe it would be beneficial to add support for mio (poll multiple FDs). This should be possible with conditional compilation.

@nastevens
Copy link
Member

This should definitely be possible in mio 0.6, which has added the Evented trait to allow custom implementations of asynchronous I/O. The actual implementation could be delegated to the underlying file descriptor. The most logical place in my mind to add this would be the PinPoller struct - adding a feature-enabled impl of Evented.

Is this something you're looking to take on @Kixunil? I've worked with mio before and would be happy to mentor if you have questions.

@Kixunil
Copy link
Author

Kixunil commented Nov 17, 2016

What's the advantage of having separate PinPoller? Is it setting correct interrupt? Also, I'm wondering how this could be integrated with Futures/Tokio.

I did try mio, so I know how to do and I'll be very happy to do it because it will improve one project I'm currently developing. However I have some things to do, which have higher priority to me. Anyway, I expect I could implement it until Christmas. What do you think?

@pheki
Copy link
Contributor

pheki commented Feb 27, 2020

Hasn't this been fixed by #26?

@Kixunil
Copy link
Author

Kixunil commented Feb 29, 2020

@pheki yeah it was, I completely forgot about this issue. Thanks for ping.

@Kixunil Kixunil closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants