-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Automated submission #7
Comments
This kind of stuff is nice but a lot of details to work through
I wonder if something like breakpad can be used. Ideally a company would offer hosting travis-style. |
Also to note: you are currently in a panicking program. Any panic in the submission process will abort. |
I wonder what the lowest effort approach to this would be? I'm thinking exposing a hook of sorts might make the most sense. e.g. have a method that on error calls some callback, and passes it a Probably would need to remove the "we take your privacy seriously, and don't do automated collection" bit for that method though. Examplehuman_panic::set_hook!(|path: PathBuf| {
// handle path here, return Result<(), Error>
}) |
I think the best approach would be what most serious programs do: do your error handling, open a separate crash-handling program. Give the user of the library the chance to choose the program, no more. Hooks within hooks within hooks doesn't seem like a good solution. |
Hi folks, I have a suggestion for easy, user-friendly report submission while preserving privacy: Github, and Gitlab-but-it's-undocumented, support URL-encoded pre-filled fields for opening issues. For Github, the documentation is here. For Gitlab, it appears that fields may be set for an issue using URL parameters of the form
I tested this with the fields So, how about if |
@cathalgarvey That is a nice approach. I wondered about auto-creating issues but that could inundate projects. Pre-filled means it still requires human action. Speaking of inundating projects, ideally, github would take whats being typed in an issue and suggest similar issues to help people avoid filing dups. |
An alternate approach with its own trade-offs/failure states[0] would be to (on next execution) detect if a/the previous execution generated an panic & offer to submit the report (or output a message indicating how to do so, e.g. via a command line flag such as While it's a different context, this pattern of "act on next run" has previously been used in GUI applications to handle e.g. document recovery and/or error reporting. Primarily mentioning this to highlight that "reporting/submitting at the time of panic" is not the only point in time that an approach can use. [0] e.g. non-interactive execution; potential impact on start-up time; etc. |
README.md list indentation and no bare URLs, as per Markdown Lint VS Code extension
Could this crate at a later date optionally allow for sending the report on behalf of the user if they allow it rather than manual submission from the user? Or would that be the responsibility of another crate that builds off this one?
The text was updated successfully, but these errors were encountered: