Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toml dependency #118

Closed
link2xt opened this issue Oct 4, 2023 · 2 comments
Closed

Remove toml dependency #118

link2xt opened this issue Oct 4, 2023 · 2 comments

Comments

@link2xt
Copy link

link2xt commented Oct 4, 2023

It is currently only used in report.rs to serialize a few strings to a file. The whole toml dependency is an overkill for this, just an additional dependency to be upgraded all the time.

String escaping could be reimplemented locally if you want to generate a valid TOML and not break compatibility, just escape the quotes and backslashes or something like this.

@epage
Copy link
Collaborator

epage commented Oct 4, 2023

Personally, I do not want to get into dealing with the correctness of doing string escaping with arbitrary content. This is with me being fairly familiar with the toml spec as I'm also the maintainer of toml and toml_edit. Cargo does this in select places (also a cargo team member) but its for very controlled text.

@link2xt link2xt closed this as completed Nov 5, 2023
@link2xt link2xt closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
@epage
Copy link
Collaborator

epage commented Nov 6, 2023

#120 upgraded toml to a version that allowed us to drop the parser, keeping only the rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants