You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #1747 the InputLength trait was removed and all bounds were transitioned over to Input. However, Input is only implemented for &[u8] and &str whereas InputLength was also implemented for (&[u8], usize), [u8; N], &[u8; N], and &[T] (for any T, not just u8).
In particular, the loss of the (&[u8], usize) implementation seems to have broken many combinators when used with items under nom::bits. In my attempt to port to nom 8, I'm running into issues with combinator::eof and multi::many_till though I expect users would run into issues using any of the functions with modified bounds under those 2 modules. (I'm not currently using anything under bytes or character so the impacts there, and due to the other dropped impls, is less clear to me.)
Here is a reduced test case that compiles for me with nom 7 but not nom 8:
In #1747 the
InputLength
trait was removed and all bounds were transitioned over toInput
. However,Input
is only implemented for&[u8]
and&str
whereasInputLength
was also implemented for(&[u8], usize)
,[u8; N]
,&[u8; N]
, and&[T]
(for anyT
, not justu8
).In particular, the loss of the
(&[u8], usize)
implementation seems to have broken many combinators when used with items undernom::bits
. In my attempt to port to nom 8, I'm running into issues withcombinator::eof
andmulti::many_till
though I expect users would run into issues using any of the functions with modified bounds under those 2 modules. (I'm not currently using anything underbytes
orcharacter
so the impacts there, and due to the other dropped impls, is less clear to me.)Here is a reduced test case that compiles for me with nom 7 but not nom 8:
The text was updated successfully, but these errors were encountered: