Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exceptions rather than swallow them #96

Open
geo2a opened this issue Feb 28, 2024 · 0 comments
Open

Log exceptions rather than swallow them #96

geo2a opened this issue Feb 28, 2024 · 0 comments

Comments

@geo2a
Copy link
Contributor

geo2a commented Feb 28, 2024

Sometimes we would like to see the raw error messages when a kup command fails. This is very useful on CI, but I do agree that we'd really want to hide that from the users by default.

I propose we log the messages of exceptions at debug level, for example here in the implementation of kup push:

    except Exception as e:
        rich.print('❗ [red]Could not push binaries to cachix!')
        logger.debug(e.msg) # we should add this
        sys.exit(1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant