Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it should be https in place of http to avoid security issues #82

Open
maheshyamsani opened this issue Aug 16, 2018 · 3 comments
Open

it should be https in place of http to avoid security issues #82

maheshyamsani opened this issue Aug 16, 2018 · 3 comments

Comments

@maheshyamsani
Copy link

var BUCKET_URL = 'http://' + location.hostname + '.' + S3_REGION + '.amazonaws.com'; // e.g. just 's3' for us-east-1 region

@rufuspollock
Copy link
Owner

@maheshyamsani what security issues here exactly and do you want to do a PR?

@ir-fuel
Copy link

ir-fuel commented Oct 8, 2018

This:

jquery.min.js:4 Mixed Content: The page at 'https://s3-eu-west-1.amazonaws.com/****/list.html' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://s3-eu-west-1.amazonaws.com.eu-west-1.amazonaws.com/?delimiter=/&prefix=****/list.html/'. This request has been blocked; the content must be served over HTTPS.

@rufuspollock
Copy link
Owner

OK, so can submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants