Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approach for handling upgrades of the gist structure #135

Open
rufuspollock opened this issue Jun 15, 2013 · 1 comment
Open

Approach for handling upgrades of the gist structure #135

rufuspollock opened this issue Jun 15, 2013 · 1 comment

Comments

@rufuspollock
Copy link
Contributor

We need a proper pattern for doing this:

  • Increase manifest_version
  • Need a function that handles changing old structure into new
  • Have a function per manifest_version change
@rufuspollock
Copy link
Contributor Author

Propose that:

  • unserializeProject function take care of checking the manifest and upgrading this
    • implication: should become async as may need to load data to do this (e.g. if this were an old style project with remote data)
  • [optional] new loadProjectFromGist function to encapsulate loading from gist

Asides:

  • Stuff like checkDatasetLoaded should become a thing of the past as all data loaded when the project loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant