Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the fields on query() #6

Open
vitorbaptista opened this issue Jan 23, 2014 · 3 comments
Open

Return the fields on query() #6

vitorbaptista opened this issue Jan 23, 2014 · 3 comments

Comments

@vitorbaptista
Copy link
Contributor

Right now, to get the fields, I need to call fetch().

As I'm calling query() anyway, it would save one request to make it return the fields as well. We already have that available, we just don't add it into the returned object.

@rufuspollock
Copy link
Contributor

A better option might be to make fetch do the default query. See also https://github.com/okfn/recline.backend.gdocs which does something similar ...

@vitorbaptista
Copy link
Contributor Author

You mean removing the query method and simply using fetch?

@rufuspollock
Copy link
Contributor

@vitorbaptista you can't remove query as you need it - ditto for fetch (i would have preferred not to have had the 2 separate methods but it seemed necessary due to recline having different backends ...). What I suggest is this:

  • fetch: just calls query with default arguments
  • query: it extracts fields and sets them

This should be pretty straightforward to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants