Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only can deep into bubbles with two or more neighbours #3

Open
dmarzo opened this issue Jan 10, 2012 · 6 comments
Open

Only can deep into bubbles with two or more neighbours #3

dmarzo opened this issue Jan 10, 2012 · 6 comments

Comments

@dmarzo
Copy link

dmarzo commented Jan 10, 2012

var data = { label: 'Total', amount: 100,
 children: [
      { taxonomy: 'cofog', name:'01', label: 'First child', amount: 30 },
      { taxonomy: '02', label: 'Second child', amount: 40 },
      { label: 'Third child', amount: 30, color: '#ff3300',
         children: [
            { label: 'First child of Third', amount: 20, color: '#ff4400' },
            { label: 'Second child of Third', amount: 10, color: '#ff4400' }
         ]} 
]};

If delete one children root, for example: node{label:'First child'}, cant navigate into children's of node{label: 'Third child''}

(Sorry for the code format, no white spaces preserved)

@gka
Copy link
Contributor

gka commented Jan 13, 2012

Thanks for reporting this. I'll fix this asap..

(fixed code snipped in issue)

@mrgcohen
Copy link

mrgcohen commented Sep 7, 2012

what's the status on this?

@Floppy
Copy link

Floppy commented Apr 24, 2013

I think this is the same bug as #15, which I've fixed in PR #24.

@greales
Copy link

greales commented Jul 15, 2013

Hi all, is this fix already?

@singold
Copy link

singold commented Nov 7, 2013

Floppy's PR fixes the issue, but I don't know if it wasn't accepted yet or what, but if you update your copy it works like a charm.
Thanks @Floppy

@fcjurado
Copy link

I think it's not fixed due to there are two different issues:
1.- Problem with undefined right nodes. It's fixed alright width the hack on #15 from @PhilippFS.
2.- When there're one node with only one children, no children nodes is printed (no dashed parent node). It's like had reported in these issues #29 and #30

Anyone can try it with this data from json. Image attached with result:
{"label":"Mdragi","amount":12,"color":"#E60202","children":[{"label":"Year 2012","amount":12,"color":"#20231c","children":[{"label":"December 2012","amount":12,"color":"#545166","children":[{"label":"Thursday 20","amount":2,"color":"#403c41","children":[{"label":"Photo 2012December20","amount":1,"color":"#668430"},{"label":"Photo 2012December20","amount":1,"color":"#67862b"}]},{"label":"Friday 21","amount":1,"color":"#4b5549","children":[{"label":"Photo 2012December21","amount":1,"color":"#689723"}]},{"label":"Wednesday 26","amount":1,"color":"#20262a","children":[{"label":"Photo 2012December26","amount":1,"color":"#457c01"}]},{"label":"Friday 28","amount":4,"color":"#3a4131","children":[{"label":"Photo 2012December28","amount":1,"color":"#536800"},{"label":"Photo 2012December28","amount":1,"color":"#7b9524"},{"label":"Photo 2012December28","amount":1,"color":"#4a8116"},{"label":"Photo 2012December28","amount":1,"color":"#7a8f2b"}]},{"label":"Sunday 30","amount":2,"color":"#4d412a","children":[{"label":"Photo 2012December30","amount":1,"color":"#56700d"},{"label":"Photo 2012December30","amount":1,"color":"#00ab8d"}]},{"label":"Monday 31","amount":1,"color":"#22100d","children":[{"label":"Photo 2012December31","amount":1,"color":"#20b0ae"}]},{"label":"Saturday 22","amount":1,"color":"#4a454f","children":[{"label":"Photo 2012December22","amount":1,"color":"#0b9597"}]}]}]}]}

captura de pantalla de 2014-03-24 13 54 58

@pwalsh pwalsh removed this from the 1.0.0 milestone Dec 15, 2015
@pwalsh pwalsh added the bug label Dec 15, 2015
@pwalsh pwalsh added this to the Backlog milestone Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants