[Regression] Drag and drop not working

[danielhjacobs]

Describe the bug

Issue with https://dnalc.cshl.edu/view/16999-Genetic-Traits.html

Ruffle behavior:

Screencast.from.01-23-2023.09.44.41.AM.webm

Expected behavior

Flash behavior:

Screencast.from.01-23-2023.09.44.04.AM.webm

Affected platform

Self-hosted version

Operating system

Linux Fedora 36

Browser

Mozilla Firefox 107

Additional information

No response

[n0samu]

Code for this is duplicated per drag and drop target, but here is an example of the relevant code, with a trace statement added:

carrier_MC.carrier_bttn.onRelease = function()
{
    stopDrag();
    trace(eval(carrier_MC._droptarget));
    if(eval(carrier_MC._droptarget) == drophere_1)
    {
        drophere_1.gotoAndStop("carrier");
        drop1 = "carrier";
    }

In Flash Player, when I drag the carrier icon onto the nearer "Drop here" box, it traces:
_level0.drophere_1
But in Ruffle, it traces:
_level0.drophere_1.instance9
Considering that Ruffle does not have DisplayObject string paths correctly implemented (see #5492), it's no surprise that this doesn't work.

[danielhjacobs]

Wait, no: This is a regression: https://ruffle-regressions.github.io/?version=0.1.0-nightly.2022.12.18 works, https://ruffle-regressions.github.io/?version=0.1.0-nightly.2022.12.19 doesn't, with https://content.dnalc.org/content/c16/16999/genetic_traits.swf.

[Lord-McSweeney]

https://github.com/ruffle-rs/ruffle/commits/master?before=f213ec40fc92ddb5e41573594b2737262d17a04c+280&branch=master&qualified_name=refs%2Fheads%2Fmaster
The only commits I see relevant are the hitTest fixes.

[danielhjacobs]

I thought the same, but in nightly-2022-12-18...nightly-2022-12-19, the only AVM1 changes are #8613

[danielhjacobs]

Actually, you're right, the actual issue is that #8744, which was supposed to just be AVM2 changes, made incorrect AVM1 changes in core/src/display_object/movie_clip.rs.