Skip to content

Desktop Tower Defense does not conclude after surviving all levels. #9052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kfchou opened this issue Jan 7, 2023 · 1 comment
Open

Desktop Tower Defense does not conclude after surviving all levels. #9052

kfchou opened this issue Jan 7, 2023 · 1 comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working

Comments

@kfchou
Copy link

kfchou commented Jan 7, 2023

Describe the bug

Desktop Tower Defense does not conclude after surviving all levels.

Expected behavior

After beating the game, a pop up appears with score submission, or a message that the game has concluded, and return to main menu.

Affected platform

Online demo

Operating system

Windows 10

Browser

Chrome

Additional information

The version of the game is hosted on https://kbhgames.com/game/desktop-tower-defense

@kfchou kfchou added the bug Something isn't working label Jan 7, 2023
@n0samu n0samu added the A-avm1 Area: AVM1 (ActionScript 1 & 2) label Jan 7, 2023
@CUB3D
Copy link
Contributor

CUB3D commented Jan 18, 2023

This is another case of #5492, when a 'creep' is defeated it's clip is removed, these are then filtered from the creep list like so:

function FilterCreeps() {
	var i = 0;
	while(i < this.creeps.length) {
		if("" + this.creeps[i] == "") {
            this.creeps.splice(i, 1);
        } else {
    		i++;
        }
    }
}

In Ruffle the strings won't get changed when the clip is removed so creeps.length == 429, but Tick() does the following check:

if(this.finished && this.creeps.length == 0)  {
	this.ShowFinish();
}

Which will never get hit in Ruffle, so the pop up won't show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants