Skip to content

Broken collision on https://www.y8.com/games/crazy_koala #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thatsprettygood opened this issue Apr 19, 2021 · 3 comments
Closed

Broken collision on https://www.y8.com/games/crazy_koala #4064

thatsprettygood opened this issue Apr 19, 2021 · 3 comments
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working

Comments

@thatsprettygood
Copy link

thatsprettygood commented Apr 19, 2021

Describe the bug
Collision is broken on level 2, making it impossible to beat.
Expected behavior
Collision is fine and the level can be beaten.
Is the problem with the Ruffle desktop app, extension, or self-hosted version?
Desktop
What platform are you using?
OS: Windows 10

@thatsprettygood thatsprettygood added the bug Something isn't working label Apr 19, 2021
@starblinky
Copy link

starblinky commented May 24, 2021

Issue is with HitTest when checking for hittest on a point.
if(mc_wall.hitTest(mc_hero.__x,mc_hero._y, true)){

It can occasionally return true even if it isn't hitting anything. I found that it thought it was hitting other parts of the level that was no where near the hero x/y coordinates. If you smooth out the graphics as much as you can, it will vastly improve this issue although won't fix it entirely. Or if you erase chunks of the level/wall to find what parts it thinks it's hitting.

@Herschel
Copy link
Member

Herschel commented Sep 1, 2022

Seems like this is actually another case of #5492, where the ground on level1 is still hitTested even on level2. Both clips have the instance name ground, but the variable isn't reset when the old one is destroyed and the new one is created.

@n0samu n0samu added the A-avm1 Area: AVM1 (ActionScript 1 & 2) label Dec 27, 2022
@relrelb
Copy link
Contributor

relrelb commented Mar 2, 2023

This was fixed by #9447, so closing.

@relrelb relrelb closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants