Skip to content

Wrong sound when sampling rate informations don't match #18389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klymins opened this issue Oct 26, 2024 · 2 comments
Open

Wrong sound when sampling rate informations don't match #18389

Klymins opened this issue Oct 26, 2024 · 2 comments
Labels
A-audio Area: Audio bug Something isn't working

Comments

@Klymins
Copy link

Klymins commented Oct 26, 2024

Describe the bug

When the sampling rate field of the DefineSound tag does not match the sampling rate of the MP3 file, the original Flash Player decodes the MP3 at the sampling rate that is defined by the tag but with the same speed as just decoding the MP3 with the builtin informations, but Ruffle ignores the sampling rate field of the DefineSound tag. Ruffle should be updated to give the same sound with the original Flash Player.

Expected behavior

Ruffle should decode the MP3 at the sampling rate that is defined by the tag but with the same speed as just decoding the MP3 with the builtin informations, so it should give the same sound with the original Flash Player.

Content Location

srunmatch.zip

Affected platform

Online demo

Operating system

Windows 10

Browser

Opera 95

Additional information

No response

@Klymins Klymins added the bug Something isn't working label Oct 26, 2024
@Lord-McSweeney Lord-McSweeney added the A-audio Area: Audio label Oct 26, 2024
@n0samu
Copy link
Member

n0samu commented Oct 26, 2024

Sounds somewhat similar to #6673

@Klymins
Copy link
Author

Klymins commented Oct 26, 2024

Sounds somewhat similar to #6673

I think it's not. Ruffle should use both the sampling rate information of the MP3 stream itself and the sampling rate field of the DefineSound tag as I described to give the same sound with the original Flash Player.

@Klymins Klymins changed the title Wrong behaviour when sampling rate informations does not match Wrong behaviour when sampling rate informations don't match Nov 1, 2024
@Klymins Klymins changed the title Wrong behaviour when sampling rate informations don't match Wrong sound when sampling rate informations don't match Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio Area: Audio bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants