avm2: Implement XML.setLocalName

Author: sleepycatcoding

core/src/avm2/e4x.rs

@@ -200,6 +200,11 @@ impl<'gc> E4XNode<'gc> {
         )
     }
 
+    /// Returns true when the node is a comment (E4XNodeKind::Comment)
+    pub fn is_comment(&self) -> bool {
+        matches!(self.0.read().kind, E4XNodeKind::Comment(_))
+    }
+
     /// Returns an iterator that yields ancestor nodes (including itself).
     pub fn ancestors(self) -> impl Iterator<Item = E4XNode<'gc>> {
         iterators::AnscIter::for_node(self)

core/src/avm2/error.rs

@@ -231,6 +231,24 @@ pub fn make_error_1089<'gc>(activation: &mut Activation<'_, 'gc>) -> Error<'gc>
     }
 }
 
+#[inline(never)]
+#[cold]
+pub fn make_error_1117<'gc>(
+    activation: &mut Activation<'_, 'gc>,
+    name: AvmString<'gc>,
+) -> Error<'gc> {
+    let err = type_error(
+        activation,
+        &format!("Error #1117: Invalid XML name: {}.", name.as_wstr()),
+        1117,
+    );
+
+    match err {
+        Ok(err) => Error::AvmError(err),
+        Err(err) => err,
+    }
+}
+
 #[inline(never)]
 #[cold]
 pub fn make_error_1118<'gc>(activation: &mut Activation<'_, 'gc>) -> Error<'gc> {

core/src/avm2/globals/XML.as

@@ -85,6 +85,7 @@ package {
         // NOTE: Docs lie, value can be anything not just XML.
         AS3 native function replace(propertyName:Object, value:*):XML;
         AS3 native function setChildren(value:Object):XML;
+        AS3 native function setLocalName(name:*):void;
 
         AS3 function valueOf():XML {
             return this;
@@ -255,6 +256,11 @@ package {
             return self.AS3::setChildren(value);
         }
 
+        prototype.setLocalName = function(name:*):void {
+            var self:XML = this;
+            self.AS3::setLocalName(name);
+        }
+
         public static const length:int = 1;
     }
 }

core/src/avm2/globals/xml.rs

@@ -2,7 +2,7 @@
 
 use crate::avm2::api_version::ApiVersion;
 use crate::avm2::e4x::{name_to_multiname, E4XNode, E4XNodeKind};
-use crate::avm2::error::type_error;
+use crate::avm2::error::{make_error_1117, type_error};
 pub use crate::avm2::object::xml_allocator;
 use crate::avm2::object::{
     E4XOrXml, NamespaceObject, QNameObject, TObject, XmlListObject, XmlObject,
@@ -166,11 +166,7 @@ pub fn set_name<'gc>(
 
     let is_name_valid = crate::avm2::e4x::is_xml_name(new_name);
     if !is_name_valid {
-        return Err(Error::AvmError(type_error(
-            activation,
-            &format!("Error #1117: Invalid XML name: {}.", new_name),
-            1117,
-        )?));
+        return Err(make_error_1117(activation, new_name));
     }
 
     node.set_local_name(new_name, activation.context.gc_context);
@@ -830,6 +826,42 @@ pub fn set_children<'gc>(
     Ok(xml.into())
 }
 
+// ECMA-357 13.4.4.34 XML.prototype.setLocalName ( name )
+pub fn set_local_name<'gc>(
+    activation: &mut Activation<'_, 'gc>,
+    this: Object<'gc>,
+    args: &[Value<'gc>],
+) -> Result<Value<'gc>, Error<'gc>> {
+    let xml = this.as_xml_object().unwrap();
+    let node = xml.node();
+    let name = args.get_value(0);
+
+    // 1. If x.[[Class]] ∈ {"text", "comment"}, return
+    if node.is_text() || node.is_comment() {
+        return Ok(Value::Undefined);
+    }
+
+    // 2. If (Type(name) is Object) and (name.[[Class]] == "QName")
+    let name = if let Some(qname) = name.as_object().and_then(|x| x.as_qname_object()) {
+        // 2.a. Let name = name.localName
+        qname.local_name()
+    // 3. Else
+    } else {
+        // 3.a. Let name = ToString(name)
+        name.coerce_to_string(activation)?
+    };
+
+    // NOTE: avmplus check, not in spec.
+    if !crate::avm2::e4x::is_xml_name(name) {
+        return Err(make_error_1117(activation, name));
+    }
+
+    // 4. Let x.[[Name]].localName = name
+    node.set_local_name(name, activation.gc());
+
+    Ok(Value::Undefined)
+}
+
 pub fn set_notification<'gc>(
     activation: &mut Activation<'_, 'gc>,
     this: Object<'gc>,

tests/tests/swfs/from_avmplus/e4x/XML/e13_4_4_34/test.toml

@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true