Skip to content

Commit 3c69bb2

Browse files
committed
web: Enforce ESLint's spaced-comment rule
1 parent 39b53c7 commit 3c69bb2

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

web/.eslintrc.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ rules:
1212
- error
1313
- argsIgnorePattern: ^_
1414
prefer-const: error
15+
spaced-comment:
16+
- error
17+
- always
18+
- block:
19+
balanced: true
1520
overrides:
1621
# TypeScript rules.
1722
- files:

web/packages/core/src/public-api.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export class PublicAPI {
6464

6565
if (prev !== undefined && prev !== null) {
6666
if (prev instanceof PublicAPI) {
67-
/// We're upgrading from a previous API to a new one.
67+
// We're upgrading from a previous API to a new one.
6868
this.sources = prev.sources;
6969
this.config = prev.config;
7070
this.invoked = prev.invoked;
@@ -76,10 +76,10 @@ export class PublicAPI {
7676
prev.constructor === Object &&
7777
prev["config"] instanceof Object
7878
) {
79-
/// We're the first, install user configuration
79+
// We're the first, install user configuration.
8080
this.config = prev["config"];
8181
} else {
82-
/// We're the first, but conflicting with someone else.
82+
// We're the first, but conflicting with someone else.
8383
this.conflict = prev;
8484
}
8585
}

web/packages/core/tools/set_version.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ let version_seal = {};
2525

2626
if (process.env.ENABLE_VERSION_SEAL === "true") {
2727
if (fs.existsSync("version_seal.json")) {
28-
//Using the version seal stored previously.
28+
// Using the version seal stored previously.
2929
version_seal = JSON.parse(fs.readFileSync("version_seal.json"));
3030

3131
version_number = version_seal.version_number;

web/packages/extension/tools/sign_xpi.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ async function sign(
2323
downloadDir: tempDir,
2424
});
2525

26-
//Since sign-addon doesn't support source upload, let's make the request
27-
//ourselves. We aren't actually using any API methods on AMOClient, just
28-
//the authentication mechanism, so this should be safe.
26+
// Since sign-addon doesn't support source upload, let's make the request
27+
// ourselves. We aren't actually using any API methods on AMOClient, just
28+
// the authentication mechanism, so this should be safe.
2929
const client = new AMOClient({
3030
apiKey,
3131
apiSecret,
3232
apiUrlPrefix: "https://addons.mozilla.org/api/v5",
3333
downloadDir: tempDir,
3434
});
3535

36-
//NOTE: The extension ID is already wrapped in curly braces in GitHub
36+
// NOTE: The extension ID is already wrapped in curly braces in GitHub.
3737
var sourceCodeUpload = client.patch({
3838
url: `/addons/addon/${encodeURIComponent(
3939
extensionId

web/packages/selfhosted/wdio.conf.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,6 @@ exports.config = {
288288
* @param {String} oldSessionId session ID of the old session
289289
* @param {String} newSessionId session ID of the new session
290290
*/
291-
//onReload: function(oldSessionId, newSessionId) {
292-
//}
291+
// onReload: function(oldSessionId, newSessionId) {
292+
// }
293293
};

0 commit comments

Comments
 (0)