diff --git a/.rubocop.yml b/.rubocop.yml index 87bc19a..7861579 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,4 +1,8 @@ --- +require: + - rubocop-rake + - rubocop-rspec + AllCops: TargetRubyVersion: 3.3.0 NewCops: enable diff --git a/Gemfile b/Gemfile index 7968107..65ce7ec 100644 --- a/Gemfile +++ b/Gemfile @@ -13,4 +13,6 @@ group :development, :test do gem "rake", "~> 13.0" gem "rspec", "~> 3.0" gem "rubocop", "~> 1.21" + gem "rubocop-rake", require: false + gem "rubocop-rspec", require: false end diff --git a/Gemfile.lock b/Gemfile.lock index aee4eed..1ef2032 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - linear-cli (0.1.2) + linear-cli (0.1.3) base64 dry-cli (~> 1.0) dry-cli-completion (~> 1.0) @@ -136,6 +136,16 @@ GEM unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.30.0) parser (>= 3.2.1.0) + rubocop-capybara (2.20.0) + rubocop (~> 1.41) + rubocop-factory_bot (2.25.1) + rubocop (~> 1.41) + rubocop-rake (0.6.0) + rubocop (~> 1.0) + rubocop-rspec (2.26.1) + rubocop (~> 1.40) + rubocop-capybara (~> 2.17) + rubocop-factory_bot (~> 2.22) ruby-progressbar (1.13.0) semantic_logger (4.15.0) concurrent-ruby (~> 1.0) @@ -157,6 +167,8 @@ DEPENDENCIES rake (~> 13.0) rspec (~> 3.0) rubocop (~> 1.21) + rubocop-rake + rubocop-rspec BUNDLED WITH 2.5.3 diff --git a/lib/linear/commands/issue/list.rb b/lib/linear/commands/issue/list.rb index b86452a..8c56ecb 100644 --- a/lib/linear/commands/issue/list.rb +++ b/lib/linear/commands/issue/list.rb @@ -7,6 +7,7 @@ module Rubyists module Linear M :issue M :user + # Namespace for CLI module CLI module Issue List = Class.new Dry::CLI::Command @@ -20,13 +21,6 @@ class List def call(**options) logger.debug "Listing issues" display issues_for(options), options - rescue SmellsBad => e - logger.error e.message - exit 1 - rescue StandardError => e - logger.error e.message - logger.error e.backtrace.join("\n") if Rubyists::Linear.verbosity > 0 - exit 5 end def issues_for(options) diff --git a/linear-cli.gemspec b/linear-cli.gemspec index afb106f..483a58f 100644 --- a/linear-cli.gemspec +++ b/linear-cli.gemspec @@ -11,7 +11,7 @@ Gem::Specification.new do |spec| spec.summary = "CLI for interacting with Linear.app." spec.description = "A CLI for interacting with Linear.app. Loosely based on the GitHub CLI" spec.homepage = "https://github.com/rubyists/linear-cli" - spec.required_ruby_version = ">= 2.6.0" + spec.required_ruby_version = ">= 3.3.0" spec.license = "MIT" spec.metadata["allowed_push_host"] = "https://rubygems.org" diff --git a/spec/linear/cli_spec.rb b/spec/linear/cli_spec.rb index 121be87..6ad87b0 100644 --- a/spec/linear/cli_spec.rb +++ b/spec/linear/cli_spec.rb @@ -2,10 +2,6 @@ RSpec.describe Linear::Cli do it "has a version number" do - expect(Linear::Cli::VERSION).not_to be nil - end - - it "does something useful" do - expect(false).to eq(true) + expect(Linear::Cli::VERSION).not_to be_nil end end