Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse dependencies page shows gems once per platform #5199

Open
Earlopain opened this issue Nov 4, 2024 · 0 comments
Open

Reverse dependencies page shows gems once per platform #5199

Earlopain opened this issue Nov 4, 2024 · 0 comments
Labels

Comments

@Earlopain
Copy link
Contributor

Steps to Reproduce

For example pry https://rubygems.org/gems/pry/reverse_dependencies

image

rest-client publishes for 4 platforms, so it appears 4 times in that list.

Expected Behavior

Show each gem only once

Current Behavior

The gem appears as often as it publishes for different platforms

Possible Solution

Would be somewhere here I suppose

has_many :incoming_dependencies, -> { where(versions: { indexed: true, position: 0 }) }, class_name: "Dependency", inverse_of: :rubygem

Can't just add platform: "ruby" though (I think)

Additional Context

There's a bit of a problem here. it's possible for platform-specific gems to have their own set of dependencies. For example, nokogiri depends on mini_portile2 only for the generic ruby platform.

I still think it's better to dedupe instead of showing the same thing multiple times without any difference.

@Earlopain Earlopain added the bug label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant