Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS integration test for "pledging opens a new Amazon tab" #131

Open
leesharma opened this issue Oct 16, 2017 · 1 comment
Open

Add JS integration test for "pledging opens a new Amazon tab" #131

leesharma opened this issue Oct 16, 2017 · 1 comment
Labels

Comments

@leesharma
Copy link
Collaborator

Context

When you click the pledge button, you should see something similar to this:

pledging flow

That Amazon tab opening is one of the most critical features of this app, but right now, it's untested.

Issue Details

This issue is to add a feature test that verifies that clicking that button opens a new tab. This will require enabling javascript for the test and probably installing some js testing dependency (selenium, capybara-webkit, etc.). If an external dependency is needed, you'll also need to update the README and possibly bin/setup with instructions.

Ideally, this solution will be cross-platform and/or auto-skip the test for folks without the required dependencies. It definitely needs to run properly on Travis CI!

@emilianoLeite
Copy link

@leesharma I'd be happy to take a stab at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants