Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you change an item name that has been used in requests, and then run request export, you get a 500 #5018

Closed
2 tasks
cielf opened this issue Feb 16, 2025 · 3 comments · Fixed by #5028
Closed
2 tasks

Comments

@cielf
Copy link
Collaborator

cielf commented Feb 16, 2025

Summary

If you change an item name that has been used in requests, and then run request export, you get a 500. Fix that.

Why?

Makes the request export useless. Needful for annual reporting at least.

Details

To see this:
As [email protected]
Change the name of an item that has been used in a request
Run the request export
Desired effect:
Export works without a nasty 500 kind of error

Criteria for completion

  • export works after item name is changed
  • tests to confirm

Further note:

ItemRequest and RequestItem are very similar but not the same thing. We have another issue in the queue to be written up about reconciling them. You might not want to go down that rabbit hole.

@coalest
Copy link
Collaborator

coalest commented Feb 19, 2025

What is the desired behavior here if the name of an item changes. Should the request export show the item name at the time the request was made, or should it show the new name? Or a combination of the two?

@coalest
Copy link
Collaborator

coalest commented Feb 19, 2025

Showing the item name at the time the request was made could lead to some weird looking results:

Image

@cielf
Copy link
Collaborator Author

cielf commented Feb 19, 2025

We want to use the current item name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants