Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL::TestPKey#test_s_generate_parameters random failures #492

Closed
voxik opened this issue Jan 18, 2022 · 3 comments
Closed

OpenSSL::TestPKey#test_s_generate_parameters random failures #492

voxik opened this issue Jan 18, 2022 · 3 comments

Comments

@voxik
Copy link

voxik commented Jan 18, 2022

Testing with Ruby 3.1, the Ruby test suite sometimes fails with the following error:

  1) Failure:
OpenSSL::TestPKey#test_s_generate_parameters [/builddir/build/BUILD/ruby-3.1.0/test/openssl/test_pkey.rb:44]:
RuntimeError expected but nothing was raised.
@rhenium
Copy link
Member

rhenium commented Jan 19, 2022

Is this with OpenSSL 3.0? Your comment in 2021-11 on the same failure: #399 (comment)

I haven't been able to reproduce it locally.

@voxik
Copy link
Author

voxik commented Jan 19, 2022

Is this with OpenSSL 3.0?

Yes, Ruby 3.1 with OpenSSL 3.0

Your comment in 2021-11 on the same failure: #399 (comment)

Ah, right, sorry, I have already forgotten about that remark. But at that time, I was not sure it is not issue with the patches backported to Ruby 3.0.2. Now it is with Ruby 3.1, so is likely not my fault (although who knows 😉)

I haven't been able to reproduce it locally.

Unfortunately, it fails just from time to time and I don't have better reproducer at hand :/

@rhenium
Copy link
Member

rhenium commented Sep 30, 2022

Running the test file repeatedly was enough to reproduce it: while ruby -Ilib -Itest/openssl test/openssl/test_pkey.rb; do :; done

It turned out to be an issue in the current OpenSSL 3.0.x. openssl/openssl#19314

@rhenium rhenium closed this as completed Sep 30, 2022
rhenium added a commit that referenced this issue Dec 22, 2022
@rhenium
test/openssl/test_pkey.rb: allow failures in test_s_generate_parameters
f2e2a5e 
The root cause has been fixed by OpenSSL 3.0.6, but Ubuntu 22.04's
OpenSSL package has not backported the patch yet.

Reference: #492
rhenium added a commit to rhenium/ruby that referenced this issue Dec 23, 2022
@rhenium
[ruby/openssl] test/openssl/test_pkey.rb: allow failures in test_s_ge…
911450b 
…nerate_parameters

The root cause has been fixed by OpenSSL 3.0.6, but Ubuntu 22.04's
OpenSSL package has not backported the patch yet.

Reference: ruby/openssl#492

ruby/openssl@f2e2a5e5ed
matzbot pushed a commit to ruby/ruby that referenced this issue Dec 23, 2022
@rhenium
[ruby/openssl] test/openssl/test_pkey.rb: allow failures in test_s_ge…
75e7b85 
…nerate_parameters

The root cause has been fixed by OpenSSL 3.0.6, but Ubuntu 22.04's
OpenSSL package has not backported the patch yet.

Reference: ruby/openssl#492

ruby/openssl@f2e2a5e5ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voxik @rhenium