Skip to content
This repository has been archived by the owner on Oct 19, 2018. It is now read-only.

add render_while_loading #242

Open
janbiedermann opened this issue Feb 5, 2018 · 1 comment
Open

add render_while_loading #242

janbiedermann opened this issue Feb 5, 2018 · 1 comment

Comments

@janbiedermann
Copy link
Contributor

the render_while_loading block would be called when a component child is loading, as error handler implemented using after_error.
Is there a better way?
This is not compatible with

render do
end.while_loading do
end

The while_loading block will never be reached.

@catmando
Copy link
Contributor

catmando commented Feb 6, 2018

for these we should use a call back

class Foo < Hyperloop::Component
  while_loading do
    IMG(src: 'spinner.png')
   end
   ...
end

and to be completely consistent with the render call back it should allow the same signature as render:

class Foo < Hyperloop::Component
  while_loading(IMG, src: 'spinner.png')
   ...
end

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants