Don't use inner HTML when using attribute #146
Comments
|
It might be fixed here - #147 - but I am frankly not very sure, plus it might do something unintended. |
|
....yep, my fix breaks something. It was an idea :) |
n11c
pushed a commit
to oasiswork/angular-gettext-tools
that referenced
this issue
Oct 3, 2016
May fix rubenv#146 (not sure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to translate custom annotation, as described here
https://angular-gettext.rocketeer.be/dev-guide/custom-annotations/
I have tooltip, I want to automatically translate it that way. HOWEVER, it is only used in pairwise tags. Like this:
<div tooltip="You have mouse on Foo!"><img src="http://example.org/foo.jpg">...</div>However, I cannot do that. Once I add
tooltipto attributes, the inner HTML is extracted.It's probably because here - https://github.com/rubenv/angular-gettext-tools/blob/master/lib/extract.js#L345 - the logic is first take inner HTML, and only when it's falsey, take the argument.
That's very unfortunate. If you really want this behaviour, it should be documented.
The text was updated successfully, but these errors were encountered: