Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data channel test currently reliant on internal signaller id #2

Open
DamonOehlman opened this issue Mar 10, 2015 · 1 comment
Open

Data channel test currently reliant on internal signaller id #2

DamonOehlman opened this issue Mar 10, 2015 · 1 comment
Assignees
@DamonOehlman

Comments

@DamonOehlman
Copy link
Member

see: https://github.com/rtc-io/rtc-quickconnect-test/blob/master/test/datachannel.js#L39

This does not work in a world of ids communicated from the server not matching with the self-assigned client id. Needs to be fixed.
@DamonOehlman DamonOehlman self-assigned this Mar 10, 2015
@DamonOehlman
Copy link
Member Author

Done significant rework to make this the case and published 1.2.0 - currently being reviewed to see if it's worked with an implementation that does announce with an id different to what is communicated to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamonOehlman DamonOehlman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DamonOehlman