Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple controllers #58

Open
rsubtil opened this issue Jun 29, 2023 · 5 comments
Open

Support multiple controllers #58

rsubtil opened this issue Jun 29, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@rsubtil
Copy link
Owner

rsubtil commented Jun 29, 2023

Currently, the addon checks for inputs for the first controller. There should be an option to specify controller index for multiplayer games.

@rsubtil rsubtil added the enhancement New feature or request label Jun 29, 2023
@mubinulhaque
Copy link

mubinulhaque commented Dec 1, 2023

My idea for this:

  • Each ControllerIcon node would have an additional variable called joy_index
  • There would be an enum called JOYPAD_INDEX that could either be:
    • LAST_JOYPAD_USED (set by default)
    • JOYPAD_0
    • JOYPAD_1
    • JOYPAD_2
    • JOYPAD_3
    • JOYPAD_4
    • JOYPAD_5
    • JOYPAD_6
    • JOYPAD_7
  • The user could change it to any of the following for any ControllerIcon node separately

Unfortunately, I am unsure as to where your code scans the first controller.

@rsubtil
Copy link
Owner Author

rsubtil commented Dec 1, 2023

I think instead of binding icons to the last used joypad, it would be better to have an enum for accepting icons from any joypad instead, which would correspond to the current behavior. Other than that yeah, I agree with your idea 👍

@TacticalLaptopBag
Copy link
Contributor

Does this also cover icons disappearing for other controllers that aren't icons for the last controller used? I'm running into issues with my game where this is happening. I'll send a video or picture later tonight to demonstrate.

@TacticalLaptopBag
Copy link
Contributor

This is the problem I'm experiencing - I'm using two controllers, one for each character. You can see when one moves, one set of icons show. When the other moves, the other set of icons show. For now, I can resolve this by just setting the textures to their respective Joypad paths, but it's more convenient to have it defined by the action.
Screencast from 2024-10-12 10-49-21.webm

@rsubtil
Copy link
Owner Author

rsubtil commented Oct 19, 2024

Hi @TacticalLaptopBag, sorry for the late response. Could you open a dedicated issue describing this problem with more detail (e.g. what controllers are being used, what and how icon paths are being used), ideally with a minimum reproduction project (MRP)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants