Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle 2.4 metadata #34

Open
sjpotter opened this issue Nov 20, 2024 · 4 comments · May be fixed by #39
Open

Doesn't handle 2.4 metadata #34

sjpotter opened this issue Nov 20, 2024 · 4 comments · May be fixed by #39

Comments

@sjpotter
Copy link

sjpotter commented Nov 20, 2024

see: https://packaging.python.org/en/latest/specifications/core-metadata/

@tylfin
Copy link
Contributor

tylfin commented Nov 26, 2024

We'll look into this, thanks for pointing it out @sjpotter

@sjpotter
Copy link
Author

sjpotter commented Nov 26, 2024

Another thing to think about, if one wants to go full into this, approaching the go struct / json mappings to mimic how python itself generates metadata.json from the METADATA/PKG-INFO files.

edit: In practice, I dont know why python does something significantly more complicated than the simple mapping you guys did, but it does :/. Not sure if its worth it to try and make them compatible, but at least something to think about.

@andriygm
Copy link

andriygm commented Dec 9, 2024

Looks like 2.3 metadata isn't supported either. Maybe an error should be bubbled up when an unsupported metadata version is present.

@andriygm
Copy link

andriygm commented Dec 9, 2024

opened #38 to address my second point here

@andriygm andriygm linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants