Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow percent % symbol for css unit (parse_length_unit()) #117

Open
chendaniely opened this issue Nov 21, 2023 · 0 comments
Open

Allow percent % symbol for css unit (parse_length_unit()) #117

chendaniely opened this issue Nov 21, 2023 · 0 comments

Comments

@chendaniely
Copy link
Member

the string checker in in parse_length_unit() is not looking for the % (https://github.com/rstudio/fontawesome/blob/b056ecaa9169b98e9d01eacbb66dd43e8b4e7cd7/R/fa.R#L195C10-L195C35)

Even though the accepted css_length_units allows for it. This causes an early stop() when tring to pass in a percent value for lenth and width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chendaniely