Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa_i() shouldn't have aria-label with role="presentation" #114

Open
gadenbuie opened this issue Oct 6, 2023 · 0 comments
Open

fa_i() shouldn't have aria-label with role="presentation" #114

gadenbuie opened this issue Oct 6, 2023 · 0 comments

Comments

@gadenbuie
Copy link
Member

fontawesome::fa_i("cloud-rain")
#> <i class="fas fa-cloud-rain" role="presentation" aria-label="cloud-rain icon"></i>

As called out in the MDN docs, aria-label shouldn't be used with role="presentation":

Note: The element with role="presentation" is not part of the accessibility tree and should not have an accessible name. Do not use aria-labelledby or aria-label.

In general, I think either the icon should be labelled or it's presentation only (or aria-hidden="true").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Next / Ready for Dev
Development

No branches or pull requests

2 participants