Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: update to dygraph.js v2.0.0 #241

Open
AllanCameron opened this issue Jan 22, 2020 · 2 comments
Open

Feature request: update to dygraph.js v2.0.0 #241

AllanCameron opened this issue Jan 22, 2020 · 2 comments

Comments

@AllanCameron
Copy link

AllanCameron commented Jan 22, 2020

After trying unsuccessfully to solve this issue on Stack Overflow, I realised it would only be possible to add custom legend formatting by upgrading the underlying dygraphs.js library to v2.0.0. Although I forked the project and got it working quite quickly with dygraph v2.0.0, there were lots of bugs caused by the change in interface between v1 and v2. Are there any plans to upgrade the R dygraphs package to the latest version of dygraph.js (which is already 2 years old)? Are there concerns about back-compatability or is it not worth the development time?

@sje-c
Copy link

sje-c commented Jun 29, 2020

On a very related note. I've found that upgrading from R 3.4.4 to R 4.0.0 and the related packages required for javascript processing, broke my custom valueFormatter and axisLabelFormatter javascript functions for dygraphs (1.1.1.6). Initially I thought the problem was the upgrade in V8 as I was using the literal JS() prior to the input to the dyAxis adjustments. However it was actually the HtmlWidgets going from 1.3 to 1.5.1 that screwed my custom legend formatting up.

Without rolling back HtmlWidgets even some old examples that people have posted just didn't even show the graph in an R Studio interactive session: https://stackoverflow.com/questions/28486510/how-to-format-dygraphs-labels-in-r-comma-separate-thousands-place

What's the etiquette on finding out the state of a package? Contributors move on, which is fair enough.

@AllanCameron I'm interested in a dygraphs v2.0.0 update as well. I'm wondering if everybody is moving to plotly and c3 now.

@GitHunter0
Copy link

GitHunter0 commented Aug 6, 2022

Hi folks, @jjallaire @przmv , any news in this regard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants