Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Node-Canvas with something else #229

Open
wswebcreation opened this issue May 29, 2024 · 3 comments
Open

Replace Node-Canvas with something else #229

wswebcreation opened this issue May 29, 2024 · 3 comments

Comments

@wswebcreation
Copy link

Hi there,

Thanks for creating this awesome module, I'm using ResembleJS for ages in my E2E image comparison modules and migrated my projects to the WebdriverIO project where it can be used to:

  • compare desktop/mobile web screenshots
  • compare mobile native app screenshots
  • scan storybook and create/compare screenshots

So far, I/other users am/are happy and we have a lot of positive responses on the stability of ResembleJS. But,..... there are also a "lot" of users that are having issues with the system dependencies for node-canvas. They vary from being unable to use canvas to not having the rights/knowledge or the possibility to adjust their images in their pipeline to make this work.

I've worked with Jimp in the past (for an OCR service) and I'm very content with the results and possibilities. Now I understand that using the same API for Web and Node would be great, but are you open to look into other dependencies for Node?

Love to hear your, and everybody else, their thoughts

@jamescryer
Copy link
Member

Hi. I'm not planning to do any significant rewrite, I don't have the time to commit to it, and the lib is stable.

I understand that the dependency on node-canvas is a problem for some end-users, and agree it would be nice to offer an alternative.

I would like to see the successor of Resemble separate browser and node comparison into two packages, with the node lib supporting multiple image processors, such as node-canvas or Jimp.

@wswebcreation
Copy link
Author

Hi @jamescryer

Thanks for taking the time to respond and I understand what you say. I'll think about what I will do for the WebdriverIO module (might just create a fork and break the browser API). I'll post some more info about my research here when I have more data

@Mohaiminul007
Copy link

please consider this:
@napi-rs/canvas it works. It'll really help us deploying to vercel and other similar environments. may be in a separate repo.

Looking forward to hear your, and everybody else, their thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants