Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding suffix to disambiguate URLs can push total slug length outside the limit #194

Open
fauxparse opened this issue Dec 24, 2016 · 1 comment
Open

Adding suffix to disambiguate URLs can push total slug length outside the limit #194

fauxparse opened this issue Dec 24, 2016 · 1 comment

Comments

@fauxparse
Copy link
Contributor

As demonstrated in test_handling_duplicate_urls_with_limits, where the :limit is given as 13, but the resulting string is 15 characters long.

I'm happy to work on a fix to address this.
@rsl
Copy link
Owner

rsl commented Jan 18, 2017

hey there. sorry about delay. if you've got an idea for a fix for this totally welcome. merged in your other change, btw. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsl @fauxparse