Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a common gotchas or FAQ in the documentation #143

Open
EnriqueSoria opened this issue Nov 4, 2023 · 3 comments
Open

Add a common gotchas or FAQ in the documentation #143

EnriqueSoria opened this issue Nov 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@EnriqueSoria
Copy link
Collaborator

EnriqueSoria commented Nov 4, 2023

@Kazhuu
Copy link

Kazhuu commented Nov 29, 2023

Would it be possible to also state somewhere that this library works on save() and delete() methods and not with django signals? What I mean by that is when I used this library for the first time for BEFORE/AFTER_DELELE hooks. I assumed these will get triggered always, even object or queryset delete() method is used. But this is not the case when queryset delete() method is used. After checking the library source code I noticed that signals are not used, hence custom delete hook will not get called when queryset delete() is used.

This issue relates a bit to the issue I opened earlier as well when when my delete hook didn't get called.

@EnriqueSoria
Copy link
Collaborator Author

Would it be possible to also state somewhere that this library works on save() and delete() methods and not with django signals? What I mean by that is when I used this library for the first time for BEFORE/AFTER_DELELE hooks. I assumed these will get triggered always, even object or queryset delete() method is used. But this is not the case when queryset delete() method is used. After checking the library source code I noticed that signals are not used, hence custom delete hook will not get called when queryset delete() is used.

This issue relates a bit to the issue I opened earlier as well when when my delete hook didn't get called.

Yeah, we will have to add something like this to explain why it doesn't work on queryset methods. Thanks for the suggestion!

@EnriqueSoria EnriqueSoria pinned this issue Jan 29, 2024
@EnriqueSoria
Copy link
Collaborator Author

Add gotcha with has_changed when combined with fields translated using django-modeltranslation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants