From a10e85e95cbb86aa432202fdf5a25be1dfd0ce58 Mon Sep 17 00:00:00 2001 From: Matt Enlow Date: Wed, 17 Jan 2024 10:26:52 -0700 Subject: [PATCH] Remove variable name clause for check that can't compile --- lib/credo/check/readability/variable_names.ex | 8 -------- .../credo/check/readability/variable_names_test.exs | 13 ------------- 2 files changed, 21 deletions(-) diff --git a/lib/credo/check/readability/variable_names.ex b/lib/credo/check/readability/variable_names.ex index b15464f3a..e23d4d4c8 100644 --- a/lib/credo/check/readability/variable_names.ex +++ b/lib/credo/check/readability/variable_names.ex @@ -40,14 +40,6 @@ defmodule Credo.Check.Readability.VariableNames do {ast, issues_for_lhs(lhs, issues, issue_meta)} end - defp traverse( - {:<-, _meta, [{:|, _comp_meta, [_lhs, rhs]}, _comp_rhs]} = ast, - issues, - issue_meta - ) do - {ast, issues_for_lhs(rhs, issues, issue_meta)} - end - defp traverse({:<-, _meta, [lhs, _rhs]} = ast, issues, issue_meta) do {ast, issues_for_lhs(lhs, issues, issue_meta)} end diff --git a/test/credo/check/readability/variable_names_test.exs b/test/credo/check/readability/variable_names_test.exs index 0f7b39b5d..42a2dc0d4 100644 --- a/test/credo/check/readability/variable_names_test.exs +++ b/test/credo/check/readability/variable_names_test.exs @@ -149,19 +149,6 @@ defmodule Credo.Check.Readability.VariableNamesTest do |> assert_issue() end - test "it should report a violation /10" do - """ - defmodule CredoSampleModule do - def some_function(param, p2, p3) do - [someValue + v2 + v3 | {someValue} <- param, v2 <- p2, v3 <- p3] - end - end - """ - |> to_source_file - |> run_check(@described_check) - |> assert_issue() - end - test "it should report a violation /11" do """ defmodule CredoSampleModule do