Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Check: presence of @impl if there is a @behaviour #89

Open
marcandre opened this issue Aug 12, 2023 · 2 comments
Open

New Check: presence of @impl if there is a @behaviour #89

marcandre opened this issue Aug 12, 2023 · 2 comments

Comments

@marcandre
Copy link

What do you want Credo to do?

While Elixir does not require @impl statements, I would like that the presence of @behaviour Anything implies the presence, somewhere in the code, of a @impl statement. Note that if there is at least one @impl statement, then Elixir enforces that they are all decorated.

In this check or separate check, I'd like that @impl true be forbidden

Which existing behaviour would change?

Note: this is similar to #13, but more basic and can be implemented statically.

@marcandre
Copy link
Author

I can provide a PR for this if this is accepted.

@rrrene
Copy link
Owner

rrrene commented Dec 7, 2023

After our conversation yesterday, I would absolutely love to see what you come up with 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants