Is the SpecWithStruct warning still relevant with new elixir static type checking?

[flaviogrossi]

What do you want Credo to do?

Currently credo emits a warning if a struct is used in a spec. The rationale is that a struct would create a dependency.

Is this still the case with newer elixir versions now that the compiler checks struct types at compile time causing the dependency anyway? Intuitively i think the structure must be loaded anyway to perform the new static type checking.

Is this warning still relevant? Should it be disabled now?

Which existing behaviour would change?

If the premise is correct, the warning should probably be disabled by default

[rrrene]

Hi Flavio,

I am no expert in Dialyzer and can not answer the question. Hopefully, someone from the community can chime in.

Since this check is an opt-in check about how to structure @spec attributes, I could imagine that it holds value even if your premise turns out to be true.