Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XXX_all returns all TerminalNode regardless of type #83

Open
oovm opened this issue Sep 29, 2023 · 3 comments
Open

XXX_all returns all TerminalNode regardless of type #83

oovm opened this issue Sep 29, 2023 · 3 comments

Comments

@oovm
Copy link

oovm commented Sep 29, 2023

If there is more than one TerminalNode type in the child node, XXX_all cannot obtain the correct leaf node type, and children_of_type will return all TerminalNode.

image

For example, the results returned by STRING_TEXT_all here include STRING_START and STRING_END
@newca12
Copy link
Contributor

newca12 commented Oct 7, 2023

Can you check that this is not already fix by #58 ?

@oovm
Copy link
Author

oovm commented Oct 7, 2023

Where can I download pre-built jars? I don't know how to build a specific branch version.

@newca12
Copy link
Contributor

newca12 commented Oct 7, 2023

This PR is not merged yet, you have no other choice than built it yourself. Github now allow to fetch PR locally : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newca12 @oovm