From 201753bee1fe5d9760c7870b327a5fe676e8328a Mon Sep 17 00:00:00 2001 From: David-Pena Date: Fri, 11 Oct 2024 21:25:52 -0700 Subject: [PATCH] fix: return when file is not a test file (#395) --- src/rules/rrd/noSkippedTests.test.ts | 23 ++++++++++++++++++++--- src/rules/rrd/noSkippedTests.ts | 2 +- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/rules/rrd/noSkippedTests.test.ts b/src/rules/rrd/noSkippedTests.test.ts index 94a4eccf..d51c37bd 100644 --- a/src/rules/rrd/noSkippedTests.test.ts +++ b/src/rules/rrd/noSkippedTests.test.ts @@ -13,7 +13,24 @@ describe('checkNoSkippedTests', () => { }) `, } as SFCScriptBlock - const fileName = 'no-skipped-tests.vue' + const fileName = 'no-skipped-tests.test.ts' + checkNoSkippedTests(script, fileName) + const result = reportNoSkippedTests() + expect(result.length).toBe(0) + expect(result).toStrictEqual([]) + }) + + it('should not report non-test files', () => { + const script = { + content: ` + const navigateSkip = async () => { + const state = getAuthFlow().getState<'onboarding_username'>(); + const nextState = await state!.actions.skip(null).run(); + getAuthFlow().handlers[nextState.name](nextState as any); + }; + `, + } as SFCScriptBlock + const fileName = 'non-test.ts' checkNoSkippedTests(script, fileName) const result = reportNoSkippedTests() expect(result.length).toBe(0) @@ -30,7 +47,7 @@ describe('checkNoSkippedTests', () => { }) `, } as SFCScriptBlock - const fileName = 'todo-tests.vue' + const fileName = 'todo-tests.test.ts' checkNoSkippedTests(script, fileName) const result = reportNoSkippedTests() expect(result.length).toBe(1) @@ -56,7 +73,7 @@ describe('checkNoSkippedTests', () => { }) `, } as SFCScriptBlock - const fileName = 'skipped-tests.vue' + const fileName = 'skipped-tests.test.ts' checkNoSkippedTests(script, fileName) const result = reportNoSkippedTests() expect(result.length).toBe(2) diff --git a/src/rules/rrd/noSkippedTests.ts b/src/rules/rrd/noSkippedTests.ts index 8406d7dd..d6e4043b 100644 --- a/src/rules/rrd/noSkippedTests.ts +++ b/src/rules/rrd/noSkippedTests.ts @@ -8,7 +8,7 @@ const results: FileCheckResult[] = [] const resetResults = () => (results.length = 0) const checkNoSkippedTests = (script: SFCScriptBlock | null, filePath: string) => { - if (!script) { + if (!script || !filePath.includes('.test')) { return }